Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Tests Setup #118

Merged
merged 7 commits into from
Sep 5, 2020
Merged

Integration Tests Setup #118

merged 7 commits into from
Sep 5, 2020

Conversation

jacqueschen1
Copy link
Member

@jacqueschen1 jacqueschen1 commented Aug 28, 2020 •
edited
Loading

🎟️ Ticket(s):
Closes #110

👷 Changes:
A brief summary of what changes were introduced.

💭 Notes:
Any additional things to take into consideration.

Wait! Before you merge, have you checked the following:

  • Serverless tests are passing (Check travis build logs, CI is currently broken)
  • PR is has approving review(s)

@cadrianxyz
Copy link
Member

Would it be better to keep the integration tests separate from the unit tests?

This way, I feel like it'll make it easier to differentiate and read/write the tests...

  • It'll also enable us to run them at separate places as well (we can make `sls invoke test only run the unit tests, and have the integration tests run in another way?)

@jacqueschen1
Copy link
Member Author

Would it be better to keep the integration tests separate from the unit tests?

This way, I feel like it'll make it easier to differentiate and read/write the tests...

  • It'll also enable us to run them at separate places as well (we can make `sls invoke test only run the unit tests, and have the integration tests run in another way?)

For sure. I just wanted to see if it runs properly on GH actions. Wont be merging this

@jacqueschen1 jacqueschen1 changed the title [DO NOT MERGE] testing integration test [WIP] Integration Tests Setup Sep 3, 2020
@jacqueschen1 jacqueschen1 changed the title [WIP] Integration Tests Setup Integration Tests Setup Sep 5, 2020
dchen150
dchen150 approved these changes Sep 5, 2020
View reviewed changes
Copy link
Contributor

@dchen150 dchen150 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dchen150 dchen150 merged commit 3e16ac2 into master Sep 5, 2020
@dchen150 dchen150 deleted the registrationTests branch September 5, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen150 dchen150 dchen150 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

integration tests setup
3 participants
@jacqueschen1 @cadrianxyz @dchen150