GET/ PATCH/ DELETE/ for stickers #184
Conversation
pzhang24
requested review from
Resocram,
dchen150 and
huangsamantha
and removed request for
Resocram and
dchen150
| path: | ||
| id: true | ||
| cors: true | ||
| authorizer: |
There was a problem hiding this comment.
We probably want this one public
There was a problem hiding this comment.
Remove everything under authorizer? Do any of the other services do this?
There was a problem hiding this comment.
Yup, here's an example
There was a problem hiding this comment.
Just wanted to be clear, do we want stickerGet to be public, or do we want stickerCreate to be public (like registrationPost is), or both? I'm going to try and wrap this ticket up.
| expect(response.statusCode).to.be.equal(200); | ||
|
|
||
| }); | ||
|
|
There was a problem hiding this comment.
After we implement the s3 functions, we will need the tests to confirm that the appropriate functions were run (e.g. we would want the sticker delete function to run the s3 delete function, and check that the correct url was deleted)
lib/s3ImageUpload.js
Outdated
| } | ||
|
|
||
| let imageData = body.image; | ||
| if (body.image.substr(0, 7) === 'base64,') { |
There was a problem hiding this comment.
is this just to check if the image is encoded in base64? is this a reliable way to check that? And what would happen if its a different encoding?
There was a problem hiding this comment.
This If statement just cleans up the input if the string starts with 'base64,'. Also, I think we're just going to make the assumption that the image needs to be encoded in base64 when it is uploaded and transmitted.
|
TODO:
|
pzhang24
requested review from
huangsamantha and
Resocram
and removed request for
huangsamantha and
Resocram
|
Closing stale PRs in |
🎟️ Ticket(s):
Closes #135, #136, #137
👷 Changes:
💭 Notes:
Any additional things to take into consideration.
Wait! Before you merge, have you checked the following: