Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(minor style comment) I think the wordCounts and timeDiffs functions could be more consistent. In wordCounts, we have a getWordCount function, and then wordCounts is a one-liner to apply .map(). The logic is generally the same for timeDiffs, but an anonymous function is used inside the map. #33

Open
alisonmyers opened this issue Sep 12, 2024 · 0 comments · May be fixed by #36
Open

(minor style comment) I think the wordCounts and timeDiffs functions could be more consistent. In wordCounts, we have a getWordCount function, and then wordCounts is a one-liner to apply .map(). The logic is generally the same for timeDiffs, but an anonymous function is used inside the map. #33

alisonmyers opened this issue Sep 12, 2024 · 0 comments · May be fixed by #36

Comments

@alisonmyers
Copy link
Contributor 

          (minor style comment) I think the `wordCounts` and `timeDiffs` functions could be more consistent. In `wordCounts`, we have a `getWordCount` function, and then `wordCounts` is a one-liner to apply `.map()`. The logic is generally the same for `timeDiffs`, but an anonymous function is used inside the map.

Originally posted by @craigdsthompson in #29 (comment)
@alisonmyers alisonmyers linked a pull request Sep 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Metric Update refactor ubc/canvas-discussion
1 participant
@alisonmyers