From 4eae6dd9a8d13ee9f6f82ab3efbdb80c64053c45 Mon Sep 17 00:00:00 2001 From: Pan Luo Date: Mon, 14 Dec 2015 23:39:04 -0800 Subject: [PATCH] Remove a filter in getMixevalResultDetail The filter was based on primary role which is incorrect. It should be based on course role. --- app/controllers/components/evaluation.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/controllers/components/evaluation.php b/app/controllers/components/evaluation.php index 4f35d1d03..51b077caf 100644 --- a/app/controllers/components/evaluation.php +++ b/app/controllers/components/evaluation.php @@ -1078,9 +1078,9 @@ function getMixevalResultDetail($groupEventId, $groupMembers, $include) $userId = isset($user['User'])? $user['User']['id'] : $user['id']; // filter out the people who are not student, they should not get result - if ($user['Role'][0]['name'] != 'student') { - continue; - } +// if ($user['Role'][0]['name'] != 'student') { +// continue; +// } // get the results for students $evalResult[$userId] = $this->EvaluationMixeval->getResultsByEvaluatee($groupEventId, $userId, $include);