Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: "post" request for links to details pages on allocation request list and allocation change request list pages #541

Open
claire-peters opened this issue Jun 20, 2023 · 1 comment

Comments

@claire-peters
Copy link
Contributor

We encountered some problems with the code in the allocation_change_list and allocation_request_list templates. When trying to click the "details" button, a malformed post request would be sent due to its being contained inside of the "form" element, resulting in an "invalid request" response for the allocation_request_list links and a 403 error for allocation_change_list links.

I've corrected this in the FASRC repository by putting the "Details" button outside of the form container and then adding a row div to keep the UI the same (the commit fixing allocation_request_list has just that change, allocation_change_list also adds the display of changed attributes to the table). I'm happy to make a PR with an adjacent fix here, if desired. If a better/more elegant fix is available, I'd also be glad to know about it.

@dsajdak
Copy link
Contributor

dsajdak commented Jun 22, 2023

@claire-peters we'd very much appreciate a PR for this. Thank you!

claire-peters added a commit to claire-peters/coldfront that referenced this issue Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants