-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eula enforcement #609
Open
jrlagrone
wants to merge
61
commits into
ubccr:main
Choose a base branch
from
SouthernMethodistUniversity:add_eula_enforcement
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add eula enforcement #609
jrlagrone
wants to merge
61
commits into
ubccr:main
from
SouthernMethodistUniversity:add_eula_enforcement
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… show up on allocation detail page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is largely based on PR #550 by @rg663 and aims to resolve #542 (and #420?)
Users added to an allocation must agree to the EULA for the associated resource, if it exists.
This adds
PendingEULA
andDeclinedEULA
statuses to allocation users. An allocation is available to an user if the status of the allocation and the users allocation status are bothActive
. An allocation may be active for some users added to it, but not all added users based on whether or not they accepted the EULA (if applicable). PI's must accept the EULA to submit an allocation request, where enabled.This attaches EULA agreements to individual allocations, but EULAs are associated with resources. This means an user has to agree to the EULA for each individual allocation on a given resource.
PIs agree to the EULA when submitting an allocation request.
Some things to consider testing (in addition to those listed in #542):
DEBUG=True PLUGIN_SLURM=True coldfront slurm_dump
and verify that output matches expectationsDeclinedEULA
->PendingEULA
status.EULA_AGREEMENT = False
should disable eula enforcement. Switching that on/off may result in some unexpected behaviors though.