Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for hasBottomTextBorder property #85

Open
rmcreyes opened this issue Jan 17, 2020 · 0 comments
Open

Remove need for hasBottomTextBorder property #85

rmcreyes opened this issue Jan 17, 2020 · 0 comments
Labels
dev type type type refactor Places we can tidy up

Comments

@rmcreyes
Copy link
Collaborator

rmcreyes commented Jan 17, 2020

Describe the part of the code base that needs to be cleaned up
Currently our events have a property called hasBottomTextBorder. It seems like this property is only true for the LandingEvent, in which case it may be better to just handle the beginning of the game differently instead of littering all our events with this property which is going to be false in most circumstances.

Provide suggestions on how we can clean this up
To be discussed

@rmcreyes rmcreyes added refactor Places we can tidy up dev type type type labels Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev type type type refactor Places we can tidy up
Projects
None yet
Development

No branches or pull requests

1 participant