Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Bucket Sizing Overflow Behavior on Different Architectures #264

Open
rossb83 opened this issue Mar 4, 2025 · 0 comments
Open

Comments

@rossb83
Copy link

rossb83 commented Mar 4, 2025

The bucket creating methods such as this one should return an error or panic if the bucket sizes overflow. Overflow behavior is inconsistent between cpu architectures:

For inputs like

tally.ExponentialDurationBuckets(time.Second, 1.3, 90)

x86 -> The last two buckets become equal negatives [..., -2562047h47m16.854775808s, -2562047h47m16.854775808s]
ARM -> The last two buckets are equal positives [..., 2562047h47m16.854775807s, 2562047h47m16.854775807s]

Given customers are already living with this behavior we should be careful about the repair

  • returning an error/panic could cause startup issues where there were none before
  • silently detecting and removing overflows inline could create inconsistent bucket sizes
  • etc..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant