Skip to content

Commit

Permalink
Update to WALA 1.6.3 (#887)
Browse files Browse the repository at this point in the history
Fixes #829 

WALA 1.6.3 supports running on JDK 21, so JarInfer now runs on JDK 21
and the tests pass.
  • Loading branch information
msridhar authored Jan 3, 2024
1 parent 6da0b8d commit b5cd1f9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
2 changes: 1 addition & 1 deletion gradle/dependencies.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def versions = [
// The version of Error Prone that NullAway is compiled and tested against
errorProneApi : errorProneVersionToCompileAgainst,
support : "27.1.1",
wala : "1.6.2",
wala : "1.6.3",
commonscli : "1.4",
autoValue : "1.10.2",
autoService : "1.1.1",
Expand Down
6 changes: 0 additions & 6 deletions jar-infer/jar-infer-lib/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,6 @@ test {
dependsOn ':jar-infer:test-android-lib-jarinfer:bundleReleaseAar'
}

tasks.named('testJdk21', Test).configure {
// Tests fail since WALA does not yet support JDK 21; see https://github.com/uber/NullAway/issues/829
// So, disable them
onlyIf { false }
}

tasks.withType(JavaCompile).configureEach {
options.compilerArgs += "--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED"
}
Expand Down

0 comments on commit b5cd1f9

Please sign in to comment.