Skip to content

Commit

Permalink
Merge branch 'master' into jdk21_cloneMetaData_updates
Browse files Browse the repository at this point in the history
  • Loading branch information
msridhar authored Jan 3, 2024
2 parents 579b60c + 257e4bb commit b7d94cf
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 13 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,16 @@ jobs:
epVersion: 2.10.0
- os: macos-latest
java: 11
epVersion: 2.23.0
epVersion: 2.24.1
- os: ubuntu-latest
java: 11
epVersion: 2.23.0
epVersion: 2.24.1
- os: windows-latest
java: 11
epVersion: 2.23.0
epVersion: 2.24.1
- os: ubuntu-latest
java: 17
epVersion: 2.23.0
epVersion: 2.24.1
fail-fast: false
runs-on: ${{ matrix.os }}
steps:
Expand Down Expand Up @@ -63,7 +63,7 @@ jobs:
with:
arguments: codeCoverageReport
continue-on-error: true
if: runner.os == 'Linux' && matrix.java == '11' && matrix.epVersion == '2.23.0' && github.repository == 'uber/NullAway'
if: runner.os == 'Linux' && matrix.java == '11' && matrix.epVersion == '2.24.1' && github.repository == 'uber/NullAway'
- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v3
with:
Expand Down
4 changes: 2 additions & 2 deletions gradle/dependencies.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import org.gradle.util.VersionNumber
// The oldest version of Error Prone that we support running on
def oldestErrorProneVersion = "2.10.0"
// Latest released Error Prone version that we've tested with
def latestErrorProneVersion = "2.23.0"
def latestErrorProneVersion = "2.24.1"
// Default to using latest tested Error Prone version
def defaultErrorProneVersion = latestErrorProneVersion
def errorProneVersionToCompileAgainst = defaultErrorProneVersion
Expand Down Expand Up @@ -48,7 +48,7 @@ def versions = [
// The version of Error Prone that NullAway is compiled and tested against
errorProneApi : errorProneVersionToCompileAgainst,
support : "27.1.1",
wala : "1.6.2",
wala : "1.6.3",
commonscli : "1.4",
autoValue : "1.10.2",
autoService : "1.1.1",
Expand Down
6 changes: 0 additions & 6 deletions jar-infer/jar-infer-lib/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,6 @@ test {
dependsOn ':jar-infer:test-android-lib-jarinfer:bundleReleaseAar'
}

tasks.named('testJdk21', Test).configure {
// Tests fail since WALA does not yet support JDK 21; see https://github.com/uber/NullAway/issues/829
// So, disable them
onlyIf { false }
}

tasks.withType(JavaCompile).configureEach {
options.compilerArgs += "--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED"
}
Expand Down

0 comments on commit b7d94cf

Please sign in to comment.