Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore another method for code coverage #844

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Oct 8, 2023

Another fix related to #828 (see also #838)

@msridhar msridhar requested a review from lazaroclapp October 8, 2023 00:08
@msridhar msridhar enabled auto-merge (squash) October 8, 2023 00:09
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (790a9ec) 86.80% compared to head (f7923d4) 86.84%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #844      +/-   ##
============================================
+ Coverage     86.80%   86.84%   +0.04%     
  Complexity     1878     1878              
============================================
  Files            74       74              
  Lines          6192     6189       -3     
  Branches       1203     1201       -2     
============================================
  Hits           5375     5375              
+ Misses          407      406       -1     
+ Partials        410      408       -2     
Files Coverage Δ
...in/java/com/uber/nullaway/dataflow/AccessPath.java 92.26% <ø> (+1.50%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@lazaroclapp lazaroclapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! An alternative is to add a unit test for the method itself, but not sure what that would really gain us in terms of actual useful testing...

@msridhar msridhar merged commit 424cf63 into uber:master Oct 8, 2023
9 checks passed
@msridhar msridhar deleted the another-nondet-test-coverage-method branch October 8, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants