Fix bug with computing direct type use annotations on parameters #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #864 +/- ##
=========================================
Coverage 87.02% 87.02%
- Complexity 1921 1922 +1
=========================================
Files 77 77
Lines 6219 6219
Branches 1209 1210 +1
=========================================
Hits 5412 5412
Misses 403 403
Partials 404 404 ☔ View full report in Codecov by Sentry. |
msridhar
commented
Nov 19, 2023
| @@ -102,7 +102,7 @@ def test = [ | |||
| "org.junit.jupiter:junit-jupiter-api:5.0.2", | |||
| "org.apiguardian:apiguardian-api:1.0.0" | |||
| ], | |||
| jetbrainsAnnotations : "org.jetbrains:annotations:13.0", | |||
| jetbrainsAnnotations : "org.jetbrains:annotations:24.1.0", | |||
There was a problem hiding this comment.
Needed so that @NotNull is a type use annotation
lazaroclapp
approved these changes
Nov 19, 2023
| "class TypeArgumentAnnotation {", | ||
| " List<@Nullable String> fSafe = new ArrayList<>();", | ||
| " @Nullable List<String> fUnsafe = new ArrayList<>();", | ||
| " void useParamSafe(List<@Nullable String> list) {", | ||
| " list.hashCode();", | ||
| " }", | ||
| " void unsafeCall() {", | ||
| " // BUG: Diagnostic contains: passing @Nullable parameter", | ||
| " useParamSafe(null);", |
There was a problem hiding this comment.
Before this change, this was a false negative? (Either way, great to have the test, but just curious)
There was a problem hiding this comment.
Yes that's right, this was a false negative before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NullAway was still treating annotations on generic type arguments as being on the top-level type of a parameter itself, which could lead to false positives and potentially also missed bugs.