Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Checker Framework 3.41.0 #873

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Dec 4, 2023

Just to stay up to date. Benchmarking results show no overhead regression, and possibly a very slight improvement.

@msridhar
Copy link
Collaborator Author

msridhar commented Dec 4, 2023

/benchmark

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1140a81) 87.04% compared to head (51dc615) 87.04%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #873   +/-   ##
=========================================
  Coverage     87.04%   87.04%           
  Complexity     1922     1922           
=========================================
  Files            77       77           
  Lines          6221     6221           
  Branches       1208     1208           
=========================================
  Hits           5415     5415           
+ Misses          404      403    -1     
- Partials        402      403    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 4, 2023

Main Branch:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25   9.184 ± 0.067  ops/s
CaffeineBenchmark.compile         thrpt   25   2.105 ± 0.020  ops/s
DFlowMicroBenchmark.compile       thrpt   25  24.384 ± 0.158  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.261 ± 0.021  ops/s

With This PR:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25   9.255 ± 0.080  ops/s
CaffeineBenchmark.compile         thrpt   25   2.113 ± 0.020  ops/s
DFlowMicroBenchmark.compile       thrpt   25  24.617 ± 0.140  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.280 ± 0.018  ops/s

@msridhar msridhar requested a review from yuxincs December 4, 2023 20:27
@msridhar msridhar enabled auto-merge (squash) December 4, 2023 20:33
Copy link
Collaborator

@yuxincs yuxincs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependency upgrade LGTM!

@msridhar msridhar merged commit eb2e19c into uber:master Dec 4, 2023
10 checks passed
@msridhar msridhar deleted the cf-3.40.1-snapshot branch December 4, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants