Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven NullAway setup not detecting anything in the project #979

Closed
Wolf2323 opened this issue Jun 15, 2024 · 2 comments
Closed

Maven NullAway setup not detecting anything in the project #979

Wolf2323 opened this issue Jun 15, 2024 · 2 comments

Comments

@Wolf2323
Copy link

I am completely new to nullaway, so may this is only a bad configuration or misunderstanding of the setup but when i run my maven project with mvn verify no errors are detected in the project (I am sure there are some) even if i copy the failing example code from the readme in my code.

maven-compiler-plugin: 3.10.1
error_prone_core: 2.27.1
nullaway: 0.10.26

The complete setup I added can be seen in this PR, I already opened in my project: https://github.com/BetonQuest/BetonQuest/pull/2812/files

@msridhar
Copy link
Collaborator

msridhar commented Jun 15, 2024

Looks like you're running into #830, which I tried to address in the Error Prone docs in google/error-prone#4162. Can you try bumping the maven-compiler-plugin version to at least 3.11.0? Alternately you can pass -Xep:NullAway:ERROR I think and you should see errors.

Please let us know if that fixes things.

@Wolf2323
Copy link
Author

Yes, updating maven-compiler-plugin solved my problem. Thank you for the fast and helpful response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants