-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for downloading result from s3 #66
base: master
Are you sure you want to change the base?
Add support for downloading result from s3 #66
Conversation
jan.kaifer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
d935473
to
b0f1f85
Compare
b0f1f85
to
8e536d2
Compare
if r.ResultOutput.NextToken == nil || *r.ResultOutput.NextToken == "" { | ||
return &r, nil | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An interesting detail is that I fetch that s3 file only if there are multiple pages. If all results are present on the first page, then we don't need to download the S3 file.
I fetch the first page every time because we need metadata information anyway (like types of columns etc.). And doing one extra request is not that problematic for large queries anyway.
context is in #65