Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ci lint job #860

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Add ci lint job #860

merged 2 commits into from
Feb 19, 2025

Conversation

PaysPlat
Copy link
Contributor

Hi,
I added support of jobs details in LintCi response when setting the switch IncludeJobs in request

@PaysPlat PaysPlat requested a review from a team as a code owner February 19, 2025 01:13
@PaysPlat PaysPlat requested review from louis-z and removed request for a team February 19, 2025 01:13
@louis-z
Copy link
Member

louis-z commented Feb 19, 2025

Thanks for your contribution, @PaysPlat.

You'll need to modify NGitLab\PublicAPI.Unshipped.txt, to document changes made to the public API. I recommend that you do so using VS2022's "Quick Actions and Refactorings..." rather than modifying the file by hand.

image

By selecting "Fix all occurrences in: Solution", it will make all the necessary changes.

@PaysPlat
Copy link
Contributor Author

Thank you for your quick feedback.
Sorry I did not know this way of declaring API, I have fixed it following your indications.

@louis-z louis-z merged commit 3ef67c3 into ubisoft:main Feb 19, 2025
5 checks passed
@PaysPlat PaysPlat deleted the add-ci-lint-job branch February 19, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-z louis-z Awaiting requested review from louis-z louis-z is a code owner automatically assigned from ubisoft/ngitlab-owners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaysPlat @louis-z