Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: rebase instructions don't include aurora #64

Closed
RealVishy opened this issue Dec 29, 2024 · 3 comments
Closed

bug: rebase instructions don't include aurora #64

RealVishy opened this issue Dec 29, 2024 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@RealVishy
Copy link
Collaborator

Describe the bug

The changelogs.py say $IMAGE_NAME

Image

What did you expect to happen?

i expect it to just say aurora

Output of bootc status

Output of groups

Extra information or context

No response

@RealVishy RealVishy added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 29, 2024
@ledif
Copy link
Collaborator

ledif commented Dec 29, 2024

I believe changing $IMAGE_NAME to just aurora here wouldn't be completely correct. The image's name can be one of many variants depending on the currently booted system: aurora, aurora-dx, aurora-nvidia, aurora-dx-nvidia, etc.

I don't think we want to give users instructions to rebase to a different image name in these notes, just a different tag.

@RealVishy
Copy link
Collaborator Author

RealVishy commented Dec 30, 2024

AFAIK the changelogs are only for stable, so the tag would be the same. Maybe we can add a sentence above the rebase instructions saying what the image types are ( -dx, -nvidia) etc.

Edit: is image name being exported to the shell? Might not need to do anything then

@RealVishy
Copy link
Collaborator Author

yeah nvm it's not a bug i just didn't read it properly, the first line figures out your image name and then rebases you to the stable channel for your system. I'll close this.

@RealVishy RealVishy closed this as not planned Won't fix, can't repro, duplicate, stale Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants