Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: switch to official upstream images #687

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

chore: switch to official upstream images #687

wants to merge 10 commits into from

Conversation

p5
Copy link
Member

@p5 p5 commented Dec 2, 2024 •
edited
Loading

Closes #669

This is fully backwards-compatible. Builds official images using the official Quay repository, but keeps building the unofficial images using the unofficial repository.

I have tested this with a Fedora 41 image, which worked exactly the same as before. I haven't tested with Fedora 40.

castrojo
castrojo reviewed Dec 2, 2024
View reviewed changes
.github/workflows/reusable-build.yml Outdated
Comment on lines 42 to 45
- image_name: sericea
base_image: quay.io/fedora/fedora-sway-atomic
- image_name: onyx
base_image: quay.io/fedora/fedora-budgie-atomic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just go with the upstream names so they end up being sway-main and budgie-main?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do, though it may be best waiting for the next major version rather than introducing breaking changes in the middle of a cycle

@castrojo
Copy link
Member

castrojo commented Dec 2, 2024

I see containers.bootc = 1 on the F40 images as well, did they push those as well? Sorry I haven't been keeping track of this as well as I should have!

@p5 p5 marked this pull request as ready for review December 2, 2024 20:51
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 2, 2024
@tulilirockz
Copy link

What about base being fedora-bootc? is that backward compatible or we cant use it yet?

@p5
Copy link
Member Author

p5 commented Dec 10, 2024 •
edited
Loading

What about base being fedora-bootc? is that backward compatible or we cant use it yet?

fedora-bootc is extremely minimal. I'd probably say too minimal for us at this time.
Current base contains all these packages, whereas bootc-base (the tier-0 and tier-x images) contain far less

Not saying we'll never switch over to fedora-bootc for the base images. But it'll need a lot more tweaking and testing than I'm able to provide right now. Hopefully Timothee will support a fedora-base-atomic image we can inherit

@fiftydinar
Copy link
Contributor

fiftydinar commented Dec 10, 2024 •
edited
Loading

But the official quay image contains bootc also. So idk what's the differentiation for the fedora-bootc image to be called like that (besides less packages).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castrojo castrojo castrojo left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use official upstream Atomic Desktop images (once they support bootc) insted of current unofficial
4 participants
@p5 @castrojo @tulilirockz @fiftydinar