Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ublue update should also use /usr/lib/ublue-update.d as well #99

Closed
dnkmmr69420 opened this issue Dec 21, 2023 · 6 comments
Closed

Comments

@dnkmmr69420
Copy link

dnkmmr69420 commented Dec 21, 2023

/usr/lib/ublue-update.d should be the least prioritized as well. It is kind of similar how udev rules and systemd unit file locations are prioritized as well.

With this change, you can have a read only location for the update scripts but users can modify them by making a new file in /etc/ublue-update.d that has the same name as the original file in /usr/lib/ublue-update.d Maybe there should be a way to blacklist an update script in /usr/lib/ublue-update.d if a user desires to disable an update script entirely. So yeah it would be handled similarly as udev-rules and systemd unit files.

Pull Request: #100

@gerblesh
Copy link
Collaborator

sounds good to me, if you'd like to PR it lmk, otherwise I could probably crank it out tomorrow!

@gerblesh
Copy link
Collaborator

ok looking further into this it looks like it might require a bit of a rethink of how the current update system works, I'm not totally sure how i'd integrate this yet but i'll definitely have a crack at it tomorrow,

@dnkmmr69420
Copy link
Author

sounds good to me, if you'd like to PR it lmk, otherwise I could probably crank it out tomorrow!

I would PR it if I know what to modify

@gerblesh
Copy link
Collaborator

sounds good to me, if you'd like to PR it lmk, otherwise I could probably crank it out tomorrow!

I would PR it if I know what to modify

you'll want to look at run_updates and run_update_scripts, run_updates runs all of the required updates, run_update_scripts runs all of the scripts in a single dir, specified as an argument

@dnkmmr69420
Copy link
Author

How do I add multiple dirs with /etc/ublue-update.d being the most prioritized?

@dnkmmr69420
Copy link
Author

closing this because of this: #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants