Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: offline iso update #87

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

bobslept
Copy link
Contributor

Fixes #86

This will always return True when we are on a offline installation which contains the oci variant oci:/var/ublue-os/image

Add another condition to verify we want to have a dbus notification

Traceback (most recent call last):
  File "/usr/bin/ublue-update", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/usr/lib/python3.11/site-packages/ublue_update/cli.py", line 255, in main
    run_updates(cli_args.system, system_update_available)
  File "/usr/lib/python3.11/site-packages/ublue_update/cli.py", line 177, in run_updates
    if "universal-blue-update-reboot" in out.stdout.decode("utf-8"):
                                         ^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'stdout'

Bump the spec version with x.x.1

@bobslept bobslept requested a review from gerblesh October 16, 2023 18:18
@gerblesh gerblesh added this pull request to the merge queue Oct 17, 2023
Merged via the queue into ublue-os:main with commit 986ed9a Oct 17, 2023
3 checks passed
@bobslept bobslept deleted the fix-offline-install branch October 17, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update service fails on offline iso install
2 participants