Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Description to Media Group #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Description to Media Group #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/domain/media/group.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import 'package:rss_dart/domain/media/content.dart';
import 'package:rss_dart/domain/media/credit.dart';
import 'package:rss_dart/domain/media/rating.dart';
import 'package:rss_dart/domain/media/thumbnail.dart';
import 'package:rss_dart/domain/media/description.dart';
import 'package:rss_dart/util/helpers.dart';
import 'package:xml/xml.dart';

Expand All @@ -12,19 +13,22 @@ class Group {
final List<Thumbnail> thumbnails;
final Category? category;
final Rating? rating;
final Description? description;

const Group({
this.contents = const <Content>[],
this.credits = const <Credit>[],
this.thumbnails = const <Thumbnail>[],
this.category,
this.rating,
this.description,
});

static Group? parse(XmlElement? element) {
if (element == null) {
return null;
}

return Group(
contents: element
.findElements('media:content')
Expand All @@ -40,6 +44,9 @@ class Group {
.toList(),
category: Category.parse(findElementOrNull(element, 'media:category')),
rating: Rating.parse(findElementOrNull(element, 'media:rating')),
description: Description.parse(
findElementOrNull(element, 'media:description'),
),
);
}
}
3 changes: 2 additions & 1 deletion lib/util/helpers.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ XmlElement? findElementOrNull(
String? namespace,
}) {
try {
return element.findAllElements(name, namespace: namespace).first;
return element.childElements
.firstWhere((child) => child.name.qualified == name);
} on StateError {
return null;
}
Expand Down
3 changes: 3 additions & 0 deletions test/atom_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@ void main() {
expect(mediaGroupThumbnail.height, '50');
expect(mediaGroupThumbnail.time, '12:05:01.123');

expect(item.media!.group!.description!.type, 'plain');
expect(item.media!.group!.description!.value, 'Some cool stuff!');

expect(item.media!.contents.length, 2);
final mediaContent = item.media!.contents.first;
expect(mediaContent.url, 'http://www.foo.com/video.mov');
Expand Down
1 change: 1 addition & 0 deletions test/xml/Atom-Media.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
<media:category>music/artist name/album/song</media:category>
<media:rating>nonadult</media:rating>
<media:thumbnail url="http://www.foo.com/keyframe1.jpg" width="75" height="50" time="12:05:01.123" />
<media:description type="plain">Some cool stuff!</media:description>
</media:group>
<media:title type="plain">The Judy's -- The Moo Song</media:title>
<media:description type="plain">This was some really bizarre band I listened to as a young lad.</media:description>
Expand Down