Skip to content

Commit

Permalink
Use a more suggestive name for the GPO server URL
Browse files Browse the repository at this point in the history
  • Loading branch information
@GabrielNagy
GabrielNagy committed Oct 26, 2023
1 parent 84d97bf commit 3d082d7
Show file tree
Hide file tree
Showing 21 changed files with 45 additions and 45 deletions.
2 changes: 1 addition & 1 deletion internal/ad/adsys-gpolist_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ func TestAdsysGPOList(t *testing.T) {
tc.objectClass = "user"
}
if tc.url == "" {
tc.url = "ldap_url"
tc.url = "adcontroller.example.com"
}

// Ticket creation for mock
Expand Down
2 changes: 1 addition & 1 deletion internal/ad/testdata/TestAdsysGPOList/golden/block_inheritance
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
RnDDepBlockInheritance GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/RnDDepBlockInheritance_GPO
RnDDepBlockInheritance GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/RnDDepBlockInheritance_GPO
6 changes: 3 additions & 3 deletions internal/ad/testdata/TestAdsysGPOList/golden/computers_truncated_at_15_characters
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Searching for account failed with: Failed to find account hostnameWithTruncatedLongName
ITDep1 GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/ITDep1_GPO
IT GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/IT_GPO
Default Domain Policy smb://ldap_url/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
ITDep1 GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/ITDep1_GPO
IT GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/IT_GPO
Default Domain Policy smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
6 changes: 3 additions & 3 deletions internal/ad/testdata/TestAdsysGPOList/golden/disabled_gpos
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
RnDDep3 GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/RnDDep3_GPO
RnD GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/RnD_GPO
Default Domain Policy smb://ldap_url/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
RnDDep3 GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/RnDDep3_GPO
RnD GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/RnD_GPO
Default Domain Policy smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
4 changes: 2 additions & 2 deletions internal/ad/testdata/TestAdsysGPOList/golden/filter_machine_only_gpos
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
RnD GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/RnD_GPO
Default Domain Policy smb://ldap_url/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
RnD GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/RnD_GPO
Default Domain Policy smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
4 changes: 2 additions & 2 deletions internal/ad/testdata/TestAdsysGPOList/golden/filter_user_only_gpos
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
IT GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/IT_GPO
Default Domain Policy smb://ldap_url/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
IT GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/IT_GPO
Default Domain Policy smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
6 changes: 3 additions & 3 deletions internal/ad/testdata/TestAdsysGPOList/golden/forced_gpo_and_blocked_inheritance
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
RnDDep2 Forced GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/RnDDep2_Forced_GPO
SubBlocked GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/SubBlocked_GPO
SubDep2BlockInheritance GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/SubDep2BlockInheritance_GPO
RnDDep2 Forced GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/RnDDep2_Forced_GPO
SubBlocked GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/SubBlocked_GPO
SubDep2BlockInheritance GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/SubDep2BlockInheritance_GPO
10 changes: 5 additions & 5 deletions internal/ad/testdata/TestAdsysGPOList/golden/forced_gpo_are_first_by_reverse_order
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
RnDDep2 Forced GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/RnDDep2_Forced_GPO
SubDep2ForcedPolicy Forced GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/SubDep2ForcedPolicy_Forced_GPO
RnDDep2 GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/RnDDep2_GPO
RnD GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/RnD_GPO
Default Domain Policy smb://ldap_url/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
RnDDep2 Forced GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/RnDDep2_Forced_GPO
SubDep2ForcedPolicy Forced GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/SubDep2ForcedPolicy_Forced_GPO
RnDDep2 GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/RnDDep2_GPO
RnD GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/RnD_GPO
Default Domain Policy smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
2 changes: 1 addition & 1 deletion ...stdata/TestAdsysGPOList/golden/krb5ccname_without_file_is_supported_by_the_samba_bindings
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Default Domain Policy smb://ldap_url/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
Default Domain Policy smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
6 changes: 3 additions & 3 deletions internal/ad/testdata/TestAdsysGPOList/golden/long_computer_name,_not_truncated
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
ITDep1 GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/ITDep1_GPO
IT GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/IT_GPO
Default Domain Policy smb://ldap_url/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
ITDep1 GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/ITDep1_GPO
IT GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/IT_GPO
Default Domain Policy smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
6 changes: 3 additions & 3 deletions internal/ad/testdata/TestAdsysGPOList/golden/machine_gpos
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
ITDep1 GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/ITDep1_GPO
IT GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/IT_GPO
Default Domain Policy smb://ldap_url/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
ITDep1 GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/ITDep1_GPO
IT GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/IT_GPO
Default Domain Policy smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
8 changes: 4 additions & 4 deletions internal/ad/testdata/TestAdsysGPOList/golden/multiple_gpos_in_same_ou
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
RnDDep1 GPO1 smb://ldap_url/SYSVOL/gpoonly.com/Policies/RnDDep1_GPO1
RnDDep1 GPO2 smb://ldap_url/SYSVOL/gpoonly.com/Policies/RnDDep1_GPO2
RnD GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/RnD_GPO
Default Domain Policy smb://ldap_url/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
RnDDep1 GPO1 smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/RnDDep1_GPO1
RnDDep1 GPO2 smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/RnDDep1_GPO2
RnD GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/RnD_GPO
Default Domain Policy smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
2 changes: 1 addition & 1 deletion internal/ad/testdata/TestAdsysGPOList/golden/no_@_in_user_name_returns_the_same_thing
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Default Domain Policy smb://ldap_url/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
Default Domain Policy smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
2 changes: 1 addition & 1 deletion internal/ad/testdata/TestAdsysGPOList/golden/no_gpo_on_ou_-_bytes
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Default Domain Policy smb://ldap_url/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
Default Domain Policy smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
2 changes: 1 addition & 1 deletion internal/ad/testdata/TestAdsysGPOList/golden/no_gpo_on_ou_-_string
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Default Domain Policy smb://ldap_url/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
Default Domain Policy smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
4 changes: 2 additions & 2 deletions internal/ad/testdata/TestAdsysGPOList/golden/no_gpoptions_fallbacks_to_0
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
NogPOptions GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/NogPOptions_GPO
Default Domain Policy smb://ldap_url/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
NogPOptions GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/NogPOptions_GPO
Default Domain Policy smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
4 changes: 2 additions & 2 deletions internal/ad/testdata/TestAdsysGPOList/golden/return_hierarchy
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
RnD GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/RnD_GPO
Default Domain Policy smb://ldap_url/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
RnD GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/RnD_GPO
Default Domain Policy smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
2 changes: 1 addition & 1 deletion internal/ad/testdata/TestAdsysGPOList/golden/return_one_gpo
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Default Domain Policy smb://ldap_url/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
Default Domain Policy smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
4 changes: 2 additions & 2 deletions ...rnal/ad/testdata/TestAdsysGPOList/golden/security_descriptor_accepted_is_for_another_user
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
RnD GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/RnD_GPO
Default Domain Policy smb://ldap_url/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
RnD GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/RnD_GPO
Default Domain Policy smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
4 changes: 2 additions & 2 deletions internal/ad/testdata/TestAdsysGPOList/golden/security_descriptor_access_denied_ignores_gpo
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
RnD GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/RnD_GPO
Default Domain Policy smb://ldap_url/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
RnD GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/RnD_GPO
Default Domain Policy smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
4 changes: 2 additions & 2 deletions internal/ad/testdata/TestAdsysGPOList/golden/security_descriptor_missing_ignores_gpo
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Failed to fetch gpo object with nTSecurityDescriptor RnDDep4_Security_descriptor_missing_GPO

RnD GPO smb://ldap_url/SYSVOL/gpoonly.com/Policies/RnD_GPO
Default Domain Policy smb://ldap_url/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}
RnD GPO smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/RnD_GPO
Default Domain Policy smb://adcontroller.example.com/SYSVOL/gpoonly.com/Policies/{31B2F340-016D-11D2-945F-00C04FB984F9}

0 comments on commit 3d082d7

Please sign in to comment.