Run certificate autoenroll with debug enabled #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When something went wrong with somes parts of autoenrollment, the user would need to download the autoenroll script and then run it manually, instead of getting the expected output when running update policies in debug mode. To avoid this cumbersome process, we now always run the script in debug mode and log the error message.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1151 +/- ##
=======================================
Coverage 91.55% 91.55%
=======================================
Files 79 79
Lines 8961 8962 +1
=======================================
+ Hits 8204 8205 +1
Misses 747 747
Partials 10 10 ☔ View full report in Codecov by Sentry. |
didrocks
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When something went wrong with some parts of autoenrollment, the user would need to download the autoenroll script and then run it manually, instead of getting the expected output when running update policies in debug mode. To avoid this cumbersome process, we now always run the script in debug mode and log the error message.