fix(test): Fix require outside of main goroutine #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a require check fails outside of the main goroutine, it causes a panic. This test is a common pattern in our projects, so I went looking for it after having golangci-lint warn about it in Ubuntu Pro for WSL.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #908 +/- ##
=======================================
Coverage 87.61% 87.61%
=======================================
Files 75 75
Lines 6694 6694
=======================================
Hits 5865 5865
Misses 492 492
Partials 337 337 ☔ View full report in Codecov by Sentry. |
didrocks
requested changes
Feb 9, 2024
didrocks
approved these changes
Feb 9, 2024
|
Feel free to merge, I think I don't have permissions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
requirecheck fails outside of the main goroutine, it causes a panic.This test is a common pattern in our projects, so I went looking for it after having golangci-lint warn about it in Ubuntu Pro for WSL.