Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: mark function arguments as unused where applicable #918

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

GabrielNagy
Copy link
Contributor

The easiest and safest approach to satisfy the revive linter, as these functions must have this exact signature. The occurrences were mostly split between Cobra and tests, hence the separate commits for easier review.

Fixes UDENG-2287

Note that the latest version of golangci-lint (currently 1.56.2) pulls in a version of gosec where the #nosec directive is sort of broken, hence the additional influx of warnings in the dependabot PR.

The easiest and safest approach to satisfy the revive linter, as these
functions must have this exact signature.
@GabrielNagy GabrielNagy requested a review from a team as a code owner February 20, 2024 15:48
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e35ef3a) 87.65% compared to head (bf0da61) 87.65%.
Report is 4 commits behind head on main.

Files Patch % Lines
cmd/adsysd/client/policy.go 60.00% 0 Missing and 4 partials ⚠️
cmd/adwatchd/commands/main.go 50.00% 1 Missing ⚠️
cmd/adwatchd/commands/version.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #918   +/-   ##
=======================================
  Coverage   87.65%   87.65%           
=======================================
  Files          76       76           
  Lines        6713     6716    +3     
=======================================
+ Hits         5884     5887    +3     
  Misses        492      492           
  Partials      337      337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should have been tedious and I’m not eager on the other project to be converted too! Nice work :)

@GabrielNagy GabrielNagy merged commit 19cfcf7 into main Feb 21, 2024
10 checks passed
@GabrielNagy GabrielNagy deleted the revive-lint branch February 21, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants