Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint(pam/integration-tests): Run all the tests with a shared authd in race mode #593

Merged
merged 20 commits into from
Feb 10, 2025

Conversation

3v1n0
Copy link
Collaborator

@3v1n0 3v1n0 commented Oct 17, 2024

Run by default all the tests using an unique instance of authd daemon running so that we can test better that all the codepaths work well with lots of concurrency.

Leaving this as a draft for now because it has dependencies on some commits of #583

UDENG-5377

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.14%. Comparing base (36511cd) to head (b9ae2a1).
Report is 336 commits behind head on main.

Files with missing lines Patch % Lines
internal/brokers/manager.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #593      +/-   ##
==========================================
- Coverage   83.43%   83.14%   -0.30%     
==========================================
  Files          83       96      +13     
  Lines        8689     9646     +957     
  Branches       74       74              
==========================================
+ Hits         7250     8020     +770     
- Misses       1111     1246     +135     
- Partials      328      380      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3v1n0 3v1n0 force-pushed the pam-tests-shared-authd branch 3 times, most recently from 4bd8ec9 to 1493b08 Compare November 22, 2024 15:37
@3v1n0 3v1n0 marked this pull request as ready for review November 22, 2024 15:48
@3v1n0 3v1n0 requested a review from a team as a code owner November 22, 2024 15:48
Copy link
Member

@denisonbarbosa denisonbarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to lie, I'm a bit worried... I like the idea of using a single instance as much as possible, but it will be handling an insane amount of requests (which is not a real use case [how many users do we expect to authenticate in the "same" moment?]).

This feels like it would be a pain to debug and fix if it starts going wrong, no? I'm just wondering if we might not be shooting ourselves in the foot here...

@adombeck, @didrocks any opinions regarding the above?

Despite the rambling: changes look good to me but a comment about naming, easy to fix.

@3v1n0
Copy link
Collaborator Author

3v1n0 commented Nov 27, 2024

Indeed it's not meant to respect a real scenario, but experience taught me that the more we stress a system, the more potential issues can arise.

So, in case we can also make this opt-in and just happen in the race job though.

@didrocks
Copy link
Member

I agree that as we don’t have a context ID, this could make things difficult.

How hard would it be to only run in this mode if we are in race mode?

@3v1n0
Copy link
Collaborator Author

3v1n0 commented Nov 29, 2024

I agree that as we don’t have a context ID, this could make things difficult.

How hard would it be to only run in this mode if we are in race mode?

Not much, it's just about inverting the logic, so it should be doable.

@3v1n0
Copy link
Collaborator Author

3v1n0 commented Dec 11, 2024

Blocked by #661 for now, let's wait to reconsider

@3v1n0 3v1n0 marked this pull request as draft December 11, 2024 05:31
@3v1n0 3v1n0 force-pushed the pam-tests-shared-authd branch 5 times, most recently from 1cc9930 to 5265441 Compare December 20, 2024 02:54
@3v1n0 3v1n0 marked this pull request as ready for review December 20, 2024 02:59
@3v1n0 3v1n0 force-pushed the pam-tests-shared-authd branch from 5265441 to efe85f9 Compare December 20, 2024 02:59
@3v1n0
Copy link
Collaborator Author

3v1n0 commented Dec 20, 2024

How hard would it be to only run in this mode if we are in race mode?

This is now handled via efe85f9

@3v1n0 3v1n0 force-pushed the pam-tests-shared-authd branch from efe85f9 to e02ae0d Compare December 20, 2024 03:08
@3v1n0 3v1n0 requested a review from denisonbarbosa December 20, 2024 03:08
@3v1n0 3v1n0 force-pushed the pam-tests-shared-authd branch from f176f2c to 3a62dcf Compare January 9, 2025 03:02
@adombeck adombeck force-pushed the pam-tests-shared-authd branch from 3a62dcf to ed3bc22 Compare January 22, 2025 23:17
@3v1n0 3v1n0 changed the title maint(pam/integration-tests): Run all the tests with a shared authd when possible maint(pam/integration-tests): Run all the tests with a shared authd in race mode Jan 22, 2025
@3v1n0 3v1n0 force-pushed the pam-tests-shared-authd branch 2 times, most recently from 8c108d7 to dc00dfe Compare January 22, 2025 23:35
@adombeck
Copy link
Contributor

adombeck commented Jan 23, 2025

I rebased on main again. I skipped ed3bc22 (from this branch) during the rebase which had conflicts with 6c1bf10 (from main). @3v1n0 please take a look if that was the correct decision.

@3v1n0 3v1n0 force-pushed the pam-tests-shared-authd branch from b8e50b5 to a159fdd Compare February 10, 2025 15:35
3v1n0 added 12 commits February 10, 2025 16:36
Use const variables to build expected example broker user names so that
we can be more reliable when testing them
…er names

This is valid for the standard case, while on specific cases we still
rely on manual names
This includes very long user names or prompt values
The integration-tests generated-users number of steps were not increased
when using passwd mode, leading to users not being requested for
password reset
… tests

So that we won't clash with other test in the suite
…l tests

So we can run a shared authd for everything
We removed the temporary dir on test cleanup but we may want to keep the
lifecycle of the daemon bound to the daemon itself instead
The user name now has only to contain the pre-check value prefix
while we don't care about its location to allow more combination of
cases (such as pre-check MFA users).
@3v1n0 3v1n0 force-pushed the pam-tests-shared-authd branch from a159fdd to 4e845b2 Compare February 10, 2025 15:46
@3v1n0 3v1n0 requested a review from adombeck February 10, 2025 15:48
… daemon

The daemon is ref-counted in order to decide when killing it, so that
multiple tests can share the same daemon if they want to
…nces

It can be useful for debugging purposes
In case of issues it allows easier debugging
…by default

In case, the env variable AUTHD_TESTS_USE_SHARED_AUTHD_INSTANCES can be
set to force it even in non-race test runs
@3v1n0 3v1n0 force-pushed the pam-tests-shared-authd branch from 4e845b2 to b9ae2a1 Compare February 10, 2025 15:49
@adombeck
Copy link
Contributor

Looking great, thanks!

@3v1n0 3v1n0 merged commit 0baa9fe into ubuntu:main Feb 10, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants