Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include libsoup-2.4 #6

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

sergio-costas
Copy link
Contributor

Since libsoup-2.4 has been removed from gnome-46-2404, it must be included directly in the snap, along with librest-0.7.

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please check only the options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Built with the candidate version of gnome-46-2404-sdk and ran with the candidate version of gnome-46-2404.

Test Configuration:

  • OS (please include version):
  • Any other relevant environment information:

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

@sergio-costas
Copy link
Contributor Author

It fails to build because it requires ubuntu/gnome-sdk#260

snapcraft.yaml Outdated Show resolved Hide resolved
Copy link

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm fine with building it but it makes the snap build longer, did you consider staging the libsoup deb instead? Or any reason that wouldn't work?

I've also some inline nitpicks

snapcraft.yaml Show resolved Hide resolved
snapcraft.yaml Outdated Show resolved Hide resolved
Since libsoup-2.4 has been removed from gnome-46-2404, it must be
included directly in the snap, along with librest-0.7.
snapcraft.yaml Show resolved Hide resolved
Copy link

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's land this one, we will revert the /candidate later

@seb128 seb128 merged commit 5ab238f into ubuntu:stable Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants