GFF-238: update CrosswalkConfig (#312)

uc-cdis · Jan 24, 2025 · 0b0d462 · 0b0d462
1 parent f3461f3
commit 0b0d462
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/packages/frontend/src/features/Crosswalk/types.ts b/packages/frontend/src/features/Crosswalk/types.ts
@@ -1,7 +1,7 @@
 export interface CrosswalkName {
-  id: string;
-  label: string;
-  description?: string;
+  id: string; // id of corsswalk entry
+  label: string; // label for the table column
+  description?: string; // TODO: optional description that will show up as a tooltip
 }
 
 interface CrosswalkInfo extends CrosswalkName {

diff --git a/packages/frontend/src/pages/Crosswalk/data.ts b/packages/frontend/src/pages/Crosswalk/data.ts
@@ -7,14 +7,13 @@ import {
 } from '../../features/Crosswalk';
 import { type NavPageLayoutProps } from '../../features/Navigation';
 import { GEN3_COMMONS_NAME } from '@gen3/core';
-import { CrosswalkMapping } from '../../features/Crosswalk/types';
 
 interface InitialCrosswalkInfo extends CrosswalkName {
   dataPath: string;
 }
 
-export interface InitialCrosswalkConfig {
-  showSubmittedIdInTable?: boolean;
+export interface InitialCrosswalkConfig
+  extends Omit<CrosswalkConfig, 'mapping'> {
   mapping: {
     source: CrosswalkName;
     external: Array<InitialCrosswalkInfo>;
@@ -32,7 +31,7 @@ export const CrosswalkPageGetServerSideProps: GetServerSideProps<
     const processedConfig = {
       showSubmittedIdInTable: initialConfig.showSubmittedIdInTable,
       idEntryPlaceholderText:
-        initialConfig?.showSubmittedIdInTable ||
+        initialConfig?.idEntryPlaceholderText ||
         'Enter IDs, one per line.\nExample:\nD334343\nC343433',
       mapping: {
         source: initialConfig.mapping.source,