Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job List status filtering fails for underlying value = "COMPLETED" #481

Open
matthew-li opened this issue Oct 18, 2022 · 0 comments
Open
Assignees
Labels
bug Something isn't working high priority Urgent

Comments

@matthew-li
Copy link
Collaborator

When the job completion plugin runs, the jobstatus of the Job it sends to the API is "COMPLETING". By contrast, when a script running later to fill in missing jobs runs, the status (taken directly from sacct) it sends is "COMPLETED".

In coldfront.core.statistics.forms.JobSearchForm, the "COMPLETING" value is mapped to the display label "Completed" so that when a user filters for jobs with status "Completed", jobs with jobstatus "COMPLETING" are returned. Jobs with jobstatus "COMPLETED" (i.e., those filled in by a script after the fact) are not returned.

  • The simplest approach is to update JobSearchForm to filter "Completing" and "Completed" separately, but this would be confusing for users.
  • Ideally, it'd be possible to map two values in a form field to the same display label.
  • Another option is to convert all "COMPLETING" values to "COMPLETED" (a) for all existing jobs and (b) in the API endpoint that the job completion plugin invokes.
@matthew-li matthew-li added bug Something isn't working high priority Urgent labels Oct 18, 2022
@matthew-li matthew-li self-assigned this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority Urgent
Projects
None yet
Development

No branches or pull requests

1 participant