Add job AD419.Jobs.PullNifaData #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sprucely
requested review from
srkirkland,
jSylvestre,
taylorkj and
laholstege
srkirkland
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently only syncing
NIFA_GL_...csv exports, because theNIFA_PGM...exports are problematic. There are plans to replace those with three separate exports that will include row identifiers.I initially tried to use CsvHelper's
CsvDataReaderwhich would have made for a nice stream pipeline from the csv download directly intoSqlBulkCopy, but alas, it's type conversion system is broken and treats all columns as strings.Partially address #1