From 7712e4371c7ae781cab931d0f70557d2e4c03f74 Mon Sep 17 00:00:00 2001
From: Lloyd Wheeler <ltwheeler@ucdavis.edu>
Date: Tue, 28 Nov 2017 15:00:18 -0800
Subject: [PATCH] StudentSupportForm: Removing unneeded logic from student
 support call form controller #1450

---
 app/instructionalSupport/instructionalSupport.html    |  6 +++---
 .../StudentSupportCallForm.html                       |  2 +-
 .../StudentSupportCallFormCtrl.js                     | 11 +----------
 .../studentSupportCallForm/services/studentActions.js |  2 +-
 4 files changed, 6 insertions(+), 15 deletions(-)

diff --git a/app/instructionalSupport/instructionalSupport.html b/app/instructionalSupport/instructionalSupport.html
index 359d6dd8d..530fb8b6c 100644
--- a/app/instructionalSupport/instructionalSupport.html
+++ b/app/instructionalSupport/instructionalSupport.html
@@ -20,21 +20,21 @@
 	<link rel="stylesheet" href="/css/neon-theme.css">
 	<link rel="stylesheet" href="/css/neon-forms.css">
 	<link rel="stylesheet" href="/css/shared.css">
+
 	<link rel="stylesheet" href="/css/instructionalSupportAssignment.css">
 	<link rel="stylesheet" href="/css/instructionalSupportCallStatus.css">
-	<link rel="stylesheet" href="/css/studentSupportCallForm.css">
-	<link rel="stylesheet" href="/css/studentSupportCallFormModal.css">
 	<link rel="stylesheet" href="/css/instructorSupportCallForm.css">
 	<link rel="stylesheet" href="/css/instructorSupportCallFormModal.css">
 	<link rel="stylesheet" href="/css/instructionalSupportCallConfig.css">
 
+	<!-- Student Support Call Form -->
 	<link rel="stylesheet" href="/css/studentComments.css">
 	<link rel="stylesheet" href="/css/studentPreferences.css">
 	<link rel="stylesheet" href="/css/teachingQualifications.css">
 	<link rel="stylesheet" href="/css/studentAvailabilities.css">
 	<link rel="stylesheet" href="/css/crnAvailable.css">
 	<link rel="stylesheet" href="/css/gridAvailable.css">
-	<link rel="stylesheet" href="/css/studentFormFreview.css">
+	<link rel="stylesheet" href="/css/studentFormReview.css">
 	<link rel="stylesheet" href="/css/confirmEligible.css">
 
 	<script src="/js/lib.js"></script>
diff --git a/app/instructionalSupport/studentSupportCallForm/StudentSupportCallForm.html b/app/instructionalSupport/studentSupportCallForm/StudentSupportCallForm.html
index 66ea8d377..56d1db4be 100644
--- a/app/instructionalSupport/studentSupportCallForm/StudentSupportCallForm.html
+++ b/app/instructionalSupport/studentSupportCallForm/StudentSupportCallForm.html
@@ -22,7 +22,7 @@
 		<ipa-modal
 			is-visible="view.state.isPreferenceCommentModalOpen"
 			header-text="Add Preference Comment">
-				<modal-proference-comments ng-if="view.state.openAddBudgetScenario" state="view.state"></add-budget-scenario>
+				<modal-proference-comments ng-if="view.state.openAddBudgetScenario" state="view.state"></modal-proference-comments>
 		</ipa-modal>
 
 		<!-- Page modules -->
diff --git a/app/instructionalSupport/studentSupportCallForm/StudentSupportCallFormCtrl.js b/app/instructionalSupport/studentSupportCallForm/StudentSupportCallFormCtrl.js
index a39d10115..9f19f43ee 100644
--- a/app/instructionalSupport/studentSupportCallForm/StudentSupportCallFormCtrl.js
+++ b/app/instructionalSupport/studentSupportCallForm/StudentSupportCallFormCtrl.js
@@ -12,22 +12,13 @@ instructionalSupportApp.controller('StudentSupportCallFormCtrl', ['$scope', '$ro
 			$scope.year = $routeParams.year;
 			$scope.termShortCode = $routeParams.termShortCode;
 			$scope.nextYear = (parseInt($scope.year) + 1).toString().slice(-2);
+
 			$scope.view = {};
 
 			$rootScope.$on('studentStateChanged', function (event, data) {
 				$scope.view.state = data;
 			});
 
-			$scope.toggleEligibilityConfirmed = function() {
-				if ($scope.view.state.supportCallResponse.eligibilityConfirmed) {
-					$scope.view.state.supportCallResponse.eligibilityConfirmed = false;
-				} else {
-					$scope.view.state.supportCallResponse.eligibilityConfirmed = true;
-				}
-
-				studentActions.updateSupportCallResponse($scope.view.state.supportCallResponse);
-			};
-
 			$scope.addPreference = function(preference) {
 				studentActions.addStudentPreference(preference);
 			};
diff --git a/app/instructionalSupport/studentSupportCallForm/services/studentActions.js b/app/instructionalSupport/studentSupportCallForm/services/studentActions.js
index 123196908..cf8f7cd48 100644
--- a/app/instructionalSupport/studentSupportCallForm/services/studentActions.js
+++ b/app/instructionalSupport/studentSupportCallForm/services/studentActions.js
@@ -1,4 +1,4 @@
-instructionalSupportApp.service('supportStaffFormActionCreators', function ($rootScope, $window, studentService, studentReducers) {
+instructionalSupportApp.service('studentActions', function ($rootScope, $window, studentService, studentReducers) {
 	return {
 		getInitialState: function (workgroupId, year, termShortCode) {
 			studentService.getInitialState(workgroupId, year, termShortCode).then(function (payload) {