Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new check for empty tables #492

Open
kennygperez opened this issue Feb 19, 2020 · 2 comments · Fixed by #725
Open

Add new check for empty tables #492

kennygperez opened this issue Feb 19, 2020 · 2 comments · Fixed by #725

Comments

@kennygperez
Copy link

Create an error for the case when the table tag has no tr's nested inside of it.

@AlanFCMV
Copy link
Member

AlanFCMV commented Dec 2, 2021

Put in pr 22 for phpally to add this rule on that side. Once that is merged it will be necessary to add the rule on the UDOIT side and update the phpally version.

@AlanFCMV AlanFCMV self-assigned this Dec 2, 2021
@AlanFCMV AlanFCMV linked a pull request Dec 3, 2021 that will close this issue
@rob-3
Copy link
Contributor

rob-3 commented Apr 25, 2022

PHPAlly has added this, but I can't seem to get it to fire correctly. I ran the raw HTML through the test suite in PHPAlly 1.1.1 and it caught it, so either we don't actually have that version (maybe the release package isn't actually the same as the changelog says?) or the issue isn't making its way to PHPAlly correctly.

Getting the Ufixit form working involves editing assets/js/Services/Ufixit.js to add a new component and editing a number of config files. It's also possible that the issue is just that I missed a config file somewhere. I recommend grepping to find where you need to edit config.

@AlanFCMV AlanFCMV removed their assignment May 3, 2024
@dmols dmols assigned dmols and unassigned dmols May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants