Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labeling: Need limit on label text #4

Open
zachberry opened this issue Aug 18, 2015 · 4 comments
Open

Labeling: Need limit on label text #4

zachberry opened this issue Aug 18, 2015 · 4 comments

Comments

@zachberry
Copy link
Member

You can paste in a lot of text into a labeling label, which can actually push the image offscreen

See:

screenshot 2015-08-18 16 19 32

@jaxbot
Copy link
Contributor

jaxbot commented Aug 21, 2015

What would be a good limit? 40 chars? 100 chars?

40:

image

100:

screen shot 2015-08-21 at 1 01 59 pm

@zachberry
Copy link
Member Author

I'm thinking 500 - which is horrible, and nobody should do that, but it doesn't cause issues and nobody should send me TBD tickets

@WilliamRADFunk WilliamRADFunk self-assigned this Sep 22, 2015
@SMason2057 SMason2057 self-assigned this Dec 18, 2015
@SMason2057 SMason2057 removed their assignment Jan 19, 2016
@FrenjaminBanklin FrenjaminBanklin self-assigned this Jan 27, 2016
@zachberry
Copy link
Member Author

QAing

@zachberry
Copy link
Member Author

https://clu.cdl.ucf.edu/materia/labeling/merge_requests/9

Tested on Chrome OS X:

  • Clicking on the scrollbar triggers a click on the label, which seems to put it back into the drawer on the left. Thinking of ditching this feature as my guess is more users would trigger this unintentionally than intentionally.
  • No scrollbar is shown in the creator, so labels are not identical between player/creator and user must have a scroll wheel to scroll.

@zachberry zachberry removed their assignment Feb 10, 2016
@iturgeon iturgeon transferred this issue from ucfopen/Materia Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants