Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing 404 config within next.config.js #78

Merged
merged 1 commit into from
Aug 27, 2023
Merged

fix: missing 404 config within next.config.js #78

merged 1 commit into from
Aug 27, 2023

Conversation

bliutech
Copy link
Member

next.config.js was missing details to properly build and export the custom 404 page in 404.js. This adds the missing config details.

@bliutech bliutech requested a review from Arc-blroth August 27, 2023 06:02
@bliutech bliutech linked an issue Aug 27, 2023 that may be closed by this pull request
Custom Next.js 404 Page #70
Closed
Arc-blroth
Arc-blroth approved these changes Aug 27, 2023
View reviewed changes
Copy link
Member

@Arc-blroth Arc-blroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on my machine

@Arc-blroth Arc-blroth merged commit 54f2394 into main Aug 27, 2023
@bliutech bliutech deleted the fix-404-config branch August 27, 2023 07:39
burturt pushed a commit that referenced this pull request Jan 10, 2024
@Arc-blroth
Merge pull request #78 from uclaacm/fix-404-config
126128e 
fix: missing 404 config within `next.config.js`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arc-blroth Arc-blroth Arc-blroth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Next.js 404 Page
2 participants
@bliutech @Arc-blroth