[FIX] use @Aplet123 isSameWeek comparator #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Arc-blroth
approved these changes
Aug 27, 2023
There was a problem hiding this comment.
tested a couple of edge cases and this seems to work so we'll let this algorithm remain victorious for now
gg @Aplet123
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
it was the wrong checkout |
burturt
pushed a commit
that referenced
this pull request
Jan 10, 2024
[FIX] use @Aplet123 isSameWeek comparator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #76
tldr: math for event belong to same week is incorrect, need to fix