Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect compiler failures and print an appropriate error message in such cases #237

Open
msridhar opened this issue Jul 15, 2024 · 0 comments

Comments

@msridhar
Copy link
Member

I believe whenever the annotator runs to either build the target itself or to build downstream deps, it expects the compilation run to succeed, i.e., complete without compilation errors. (NullAway needs to be run at the WARNING level for this to occur.) If this is true, then annotator should detect when a build command fails, print an appropriate error message, and terminate the run. Right now, the annotator ignores build failures, which often leads to an incrutable failure later in the annotator run, like crashing due to the absence of some expected tsv file.

This could be implemented by directly checking the return code of the executed command in executeCommand or at callers of this function if that's better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant