Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates method signature serialization for Nonull formal parameters #213

Merged
merged 5 commits into from
Nov 17, 2023

Conversation

nimakarimipour
Copy link
Member

This PR fixes #212 by updating method signature serialization for nonnull formal parameters. It reuses the existing serialization methods for symbols that ensure the correct method signature is printed.

@nimakarimipour nimakarimipour added the bug Something isn't working label Nov 17, 2023
@nimakarimipour nimakarimipour self-assigned this Nov 17, 2023
Copy link
Member

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nimakarimipour nimakarimipour merged commit e085b64 into master Nov 17, 2023
6 checks passed
@nimakarimipour nimakarimipour deleted the nimak/nonnull branch November 17, 2023 02:43
nimakarimipour added a commit that referenced this pull request Nov 17, 2023
)

Followup to #213, this PR fixes symbol serialization in all `Location` subclasses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong serialization of @NotNull formal parameters with type use annotation
2 participants