Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Project Refactor (MVC) #87

Open
joelbagan opened this issue Nov 13, 2017 · 1 comment
Open

General Project Refactor (MVC) #87

joelbagan opened this issue Nov 13, 2017 · 1 comment

Comments

@joelbagan
Copy link
Contributor

CountryRunnerJPanel.java is over 500 lines long. Without reading the code, one can safely assume this class is responsible for more than one aspect of the application. Consider refactoring this class and the project as a whole into separate packages (i.e. model, view, controller) where each class is only responsible for one aspect.

For example, CountryRunnerJPanel.java should only be responsible for updating the actual GUI, and it should ask (or be told by) the controller to update with provided information that the controller gets from the model (Information about the game's state).

F17 OK 250pts

@Sierrasch
Copy link
Contributor

W18 OK 250 pts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants