Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with all the supported ghc's #27

Merged
merged 8 commits into from
May 17, 2024

Conversation

facundominguez
Copy link
Contributor

No description provided.

@facundominguez facundominguez force-pushed the fd/all-ghcs branch 2 times, most recently from 4eea296 to d3eb465 Compare May 16, 2024 02:53
@facundominguez
Copy link
Contributor Author

facundominguez commented May 16, 2024

Caching in CI needs some more care. We would need to generate all of the lock files for all of the configurations to merge them and add them to the cache keys. I'm leaving that for another day.

@facundominguez facundominguez force-pushed the fd/all-ghcs branch 2 times, most recently from 64d36d0 to ddaaede Compare May 16, 2024 11:52
@ranjitjhala
Copy link
Member

Looks great @facundominguez thank you!

@ranjitjhala
Copy link
Member

Shall I merge it or will you?

@facundominguez
Copy link
Contributor Author

I have no commit rights here, so it is all yours.

@ranjitjhala ranjitjhala merged commit 54ee80f into ucsd-progsys:main May 17, 2024
11 checks passed
@ranjitjhala
Copy link
Member

Thanks @facundominguez let me give you commit access too!

@facundominguez facundominguez deleted the fd/all-ghcs branch May 17, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants