Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable name letter is misleading #12

Open
robertdavidwest opened this issue May 23, 2023 · 0 comments
Open

Variable name letter is misleading #12

robertdavidwest opened this issue May 23, 2023 · 0 comments

Comments

@robertdavidwest
Copy link

Hello, this is pretty minor but I thought it would be useful for future students. This variable name letter is misleading. It makes it sound like the job will iterate over a string, I think this could confuse people.

I propose changing the variable name to item.

https://github.com/udacity/nd027-c3-data-lakes-with-spark/blob/master/Debugging_And_Optimization/exercises/starter/practice_broadcast_joins/broadcast_example.py#L12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant