This repository has been archived by the owner on Nov 10, 2020. It is now read-only.
forked from Jbcampbe/genesys-webcomponents
-
Notifications
You must be signed in to change notification settings - Fork 1
feat(tag flyout menu): flyout menu implementation #6
Open
AAPK-code
wants to merge
1
commit into
master
Choose a base branch
from
flyout-menu
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAPK-code
force-pushed
the
flyout-menu
branch
from
September 14, 2020 15:10
9e8b51f
to
15e10dd
Compare
Klimonov
approved these changes
Sep 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dmitryueno
reviewed
Sep 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me, but I think we also need to have some kind of event, which will fire once flyout menu option was clicked!
dmitryueno
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Klimonov
added a commit
that referenced
this pull request
Sep 23, 2020
Klimonov
added a commit
that referenced
this pull request
Sep 24, 2020
Klimonov
added a commit
that referenced
this pull request
Sep 24, 2020
Klimonov
added a commit
that referenced
this pull request
Sep 28, 2020
Klimonov
added a commit
that referenced
this pull request
Oct 1, 2020
Klimonov
added a commit
that referenced
this pull request
Oct 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.