-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround: pop-up disappears in Safari 16.4 #128
Comments
Could be a Safari bug since 16.4 is still beta? |
unfortunately i don't thinks developers update this app anymore |
I'm a collaborator developer. It will be updated if required. |
i'm glad to hear that! |
That's right Polyglot is not working for Safari 16.4! |
Looking into this now. |
OK, I have fixed the issue in PR #130. I am trying to contact @uetchy to merge my fix. Problem was Safari 16.4 is more strict about some invalid CSS used in the extension for the past 6 years (ref) problem (previously ignored by WebKit/Safari)
should be the more valid:
Reported as WebKit bug 254590 and I feel they will correct this regression going forward. Meanwhile:
|
cc @idhun90 OK, here's a temporary workaround. Let me know if you find it not working on a particular page or site. Workaround
ResultsScreen.shot.2023-03-28.at.17.57.25.mov |
is working, but we need update for app and what translation services polyglot is using? |
Update : is not working in discord, YouTube, Twitter and more |
Yes, of course the app needs to be updated.
Google Translate, with its usage terms.
I made a small tweak to the contents of the CSS file, please check above and redo the CSS.
New version works on all sites. DiscordYouTubeNote:Please be aware that the translation popup does not always appear when you select text: it only appears for words or phrases that return translation results. |
is work perfectly everywhere now |
I confirm that the new version works accurately on all sites. Thank you! |
The issue causing this problem has been identified as a bug fix in WebKit. But a remaining bug has been found which I believe should mean this issue should eventually go away when the fix reaches Safari. |
@sotnikov-nk |
Just want to say a big tnx for fixing this issue, I did this "polyglot css" and seems that the translator is working as it should! |
Great! Thanks a lot! @gingerbeardman |
The workaround worked for me too. Thank you very much for supporting this extension. I appreciate you. |
@Extravagangsta thank you - your comment made my day :) |
Thousand thanks for your quick fix, @gingerbeardman 👏 I ❤️ Polyglot and it is an essential Safari extension for me that brings a big productivity. From what I understand after a quick read of the CSS specs, Your temporary workaround works as a charm ✅ However, for those who use different computers and accounts, it requires to set up this multiple times. @uetchy did a great work creating Polyglot. It is a pity if he/she is not reachable, would you consider the possibility to publish a fork? The ideal would be to have a single Polyglot extension, but thinking on the future, that may be convenient in the case that other issues arise. Since it is published under the Apache License, Version 2.0, that looks possible. PS: there is the author's email here. I will send them a message. |
@rogerpro Even if some contributors approve my CSS change I think Uetchy would still need to publish to the App Store. if Uetchy doesn't reply, or return, and Polyglot breaks again or is removed from the App Store, I'll create a fork. It won't be able to replace the official version on the App Store, so it will still require people to find this page and download the new version. I hope Uetchy is OK. ❤️ |
@gingerbeardman The CSS solution helped! Thank you Matt! 👏 |
@gingerbeardman Hi, macOS 13.4 update did thing similar again 🥲, some pages (like this issue track) show an empty blurred box, until scrolling page it shows on, but in Reddit pages the float dialog design couldn't help. It might be caused by another css problem? |
i got same problem. but i re import same css. do it css apply again |
Hi @CatalystM47 thx reply |
oh...right? Im sorry to hear that.. |
I'm running:
But you can help me debug:
|
Actually, I can reproduce it if I am careful. @pilisir The panel can sometimes appear as blurred, but if I move the mouse or scroll the document it finally appears. There is another problem! Reported as WebKit Bug#257023 try this
|
@gingerbeardman thanks reply. Here is my reproduce screenshot. I try to add the new css property you provided, animation, and it seems to work. UPDATE: |
the workaround Is working on MacOS 13.3.1, Thanks a lot! |
@gingerbeardman let us know if you fork and publish a new extension. Thanks. |
No immediate plans, but of course I'll let you know. Currently trying to help WebKit team reproduce the 16.5 blurry bug. |
@pilisir I am running without the blurry fix, and it is not currently happening for me. So, I'm wondering what situation triggers it? Do you have any steps that will guarantee reproducing the blurry popup? |
@gingerbeardman |
I was able to reproduce it immediately in Safari Tech Preview after posting my earlier message. I'm not sure why WebKit people are unable to reproduce it. |
Is the owner still alive? The css works on Safari 16.5, perhaps someone could publish a new extension |
it's a tough question I have thought about. We don't know, so... maybe.
It is probably the only way forward for long term future. Maybe I will try to create a fork closer to macOS Sonoma release. If I was to do it, I would try to simplify the code so that it would not break, and also so that it does not rely on so many dependencies (which cause it to need updating regularly). |
I followed the comments here. I can confirm that on Version 16.5.1 (18615.2.9.11.7) Safari it works but It doesn't work when right clicking to translate the whole page, nothing happens. |
Please let me know steps and I'll try to find a workaround. I have never use full page translation via Polyglot! |
@gingerbeardman indeed, I never used highlighting translations since usually it's the whole page that is the language. |
I use Safari built-in translate for full pages and sometimes an app extension called Myna Translate to translate whole pages. Even the free version works. https://macdownload.informer.com/myna-translate-for-safari/amp/ |
Description
The pop-up with translation immediately disappears after appearing in Safari 16.4
To Reproduce
The bug occurs both when translating with shortcuts and when using instant translation.
Expected behavior
No response
Screenshots
No response
What's My Browser Link
https://www.whatsmybrowser.org/b/UKVT2
Polyglot Version
3.4.0
Additional context
No response
The text was updated successfully, but these errors were encountered: