Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Button to hide popup without deselecting text #72

Open
gingerbeardman opened this issue Dec 24, 2019 · 6 comments
Open

[REQ] Button to hide popup without deselecting text #72

gingerbeardman opened this issue Dec 24, 2019 · 6 comments

Comments

@gingerbeardman
Copy link
Collaborator

gingerbeardman commented Dec 24, 2019

Is your feature request related to a problem? Please describe.
Polyglot translates all selected text, no mater what language, so it become difficult to select text for the purposes of copy and paste or quoting using web app forum popup.

Describe the solution you'd like
I'd like a button to hide popup without deselecting text

Describe alternatives you've considered
I have to select far more than the text I want as a workaround, see #70 (Maybe a 'copy' button)

Additional context
Also see #29 (only translate "foreign" text)

@gingerbeardman gingerbeardman changed the title Button to hide popup without deselecting text [REQ] Button to hide popup without deselecting text Dec 24, 2019
@uetchy
Copy link
Owner

uetchy commented Dec 24, 2019

not sure of the situation you are facing. You can copy the text in the Polyglot panel. If it's about instant mode, I think it's faster to turn off instant mode or consider adding a toolbar button to switch instant translation feature. Furthermore, I think we can change the behavior in instant mode to cope with this issue.

@gingerbeardman
Copy link
Collaborator Author

The polyglot panel hides things that I need to click.

@uetchy
Copy link
Owner

uetchy commented Dec 24, 2019

You can dismiss the panel clicking outside it.
Adding a toolbar button to switch instant mode looks like a simpler solution to this.
I don't use instant mode, and for such users, the hide button sounds a little too much complicated.

@gingerbeardman
Copy link
Collaborator Author

Clicking outside panel also closes the web-app-ui that appeared on selection.

@gingerbeardman
Copy link
Collaborator Author

I think Escape to close panel would be easy?

I will find time to add it myself.

@uetchy
Copy link
Owner

uetchy commented Dec 25, 2019

@gingerbeardman awesome!
If you find any problem with the development setup, leave a comment here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants