-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screen junk with latest update #88
Comments
I'm not able to reproduce using https://ar.wikipedia.org/wiki/بدر_البوسعيدي as a test |
Sorry - the site is fm.gov.om and I'm finding this issue each time I turn Polyglot back on. My co-workers are finding the same issue. |
that's the problem! What type of edit control is the page using? |
It's the Avada theme, which has its own editing environment. Previously Polyglot was unable to translate Arabic text within the editor window, so it wasn't an issue. I think I should just remember not to use it here. By the way, Polyglot is a fantastic tool. Exactly what I need. Thank you! |
I have also had Polyglot leaving text inside of text fields after selecting text in text field. I was editing an item on archive.org at the time. |
Yes, it seems to happen when you translate text inside an edit field. Works fine on non-editing web pages.
… On 12 Feb 2021, at 10:01, Matt Sephton ***@***.***> wrote:
I have also had Polyglot leaving text inside of text fields after selecting text in text field. I was editing an item on archive.org at the time.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#88 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYV46QEHKPZ7N2P7ATM3STS6T355ANCNFSM4WK2VD4Q>.
|
No, you can still translate - but the extra code is inserted when you do.
… On 13 Feb 2021, at 13:37, Matt Sephton ***@***.***> wrote:
I thought that in #28 <#28> translation was disabled in text field? @uetchy <https://github.com/uetchy>
because it's most likely the words in there are either in your own language, or words I am typing myself!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#88 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAYV46WDTUNV7JLPXN3K76DS6Z6CTANCNFSM4WK2VD4Q>.
|
I am getting this in every text area:
It's very disruptive because I have to check and delete the stray html |
Actually I couldn't reproduce this bug. Could you give me a complete and precise procedure to reproduce the bug? |
Sure! it is too easy to lose control of the popup and for its HTML to be saved with the contents of the text area. Screen recording: Setup:
Problems:
Next, without dismissing the popup:
Problem:
|
Disabling handling |
I'll also think about this problem. |
Just to make some notes on possible exclusion list of selectors:
An option to disable in iframe could be possible? Or only disable iframe on certain sites? This would only fix Internet Archive. Could the popup be created at top level of DOM? Immediately after body tag, and then positioned absolutely? Just thinking out loud. |
Describe the bug
When Polyglot is loaded, a pages with Arabic text shows an always-on grey box. Text highlighted for translation shows a spinning box top left.
Screenshots
Always-on box at top, highlighted translation bottom.
Version (please complete the following information):
The text was updated successfully, but these errors were encountered: