Skip to content

Commit

Permalink
src/reports.py: Add reviewer name in completed button, fix members no…
Browse files Browse the repository at this point in the history
…t being fired until 5 missing reports, remove hanging embed after completing reports
  • Loading branch information
cbrxyz committed Nov 17, 2024
1 parent eac0cad commit 1a9c471
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/reports.py
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ async def callback(self, interaction: discord.Interaction):
new_score = self.student.total_score + 1

# Notify necessary people
if new_score > 4:
if new_score >= 4:
# Student needs to be fired
logger.warn(
f"Sending firing email for {self.student} (new score: {new_score} > 4)...",
Expand Down Expand Up @@ -494,13 +494,14 @@ async def start(self, interaction: discord.Interaction, _: discord.ui.Button):
await interaction.edit_original_response(
content="✅ Nice work. All reports have been graded. Thank you for your help!",
view=None,
embed=None,
attachments=[await self.bot.good_job_gif()],
)
view = MILBotView()
view.add_item(
discord.ui.Button(
style=discord.ButtonStyle.secondary,
label="Review Complete",
label=f"Review completed by {interaction.user.display_name}",
disabled=True,
),
)
Expand Down

0 comments on commit 1a9c471

Please sign in to comment.