Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate simulated and world camera topic names to consistent format #1281

Open
cbrxyz opened this issue Sep 25, 2024 · 4 comments · May be fixed by #1297
Open

Migrate simulated and world camera topic names to consistent format #1281

cbrxyz opened this issue Sep 25, 2024 · 4 comments · May be fixed by #1297
Assignees
Labels

Comments

@cbrxyz
Copy link
Member

cbrxyz commented Sep 25, 2024

What needs to change?

Right now, the simulated camera topics show up as:

/wamv/sensors/cameras/front/left/image_raw

The real-life camera topics show up as:

/camera/front/left/image_raw

We should migrate these topic names (and nodes who use them) to a consistent format!

How would this task be tested?

  1. Ensure that all tests pass and NaviGator doesn't break once these changes are made!
@thadavale thadavale self-assigned this Sep 27, 2024
@thadavale
Copy link

This week, I created a branch for this topic and began looking into the topic names and the nodes that use them. I also began compiling a list of files that use the relevant topic names and researching how to migrate topic names.

@thadavale
Copy link

thadavale commented Oct 7, 2024

This week I updated all of the rostopic names to be consistent with each other and worked on ensuring the existing tests still worked. However, the camera info is not able to be found currently, so I will work on fixing this error next.

@lynettehemingway lynettehemingway self-assigned this Oct 14, 2024
@lynettehemingway
Copy link

This week I was unable to work on as much as I would like due to the hurricane. However, I learned how to migrate topic names and plan on helping fix the camera info error.

@thadavale
Copy link

This week, I tried many different methods and was finally able to fix the error I previously encountered by remapping the old simulation-specific topic names onto the new real-life topic names inside simulation.launch and vrx_classifier.launch. I also made a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants