Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create async electrical_protocol driver #1283

Open
cbrxyz opened this issue Sep 27, 2024 · 2 comments
Open

Create async electrical_protocol driver #1283

cbrxyz opened this issue Sep 27, 2024 · 2 comments

Comments

@cbrxyz
Copy link
Member

cbrxyz commented Sep 27, 2024

What needs to change?

Currently, we have a synchronous version of the serial driver used by electrical_protocol. However, it would be great to have an asynchronous version of this driver. This would empower us to combine our electrical drivers with other forms of I/O (including ROS nodes/topics/etc.).

This could be done by copying the current synchronous driver and replacing the synchronous parts with pyserial-asyncio and asyncio. I also made some brief starting progress on this task on this branch.

How would this task be tested?

  1. Copy the current test cases for the synchronous driver and ensure that the test cases also pass in the asynchronous version.
@MarcinPlaza
Copy link

Well sad moment, I thought I would finish by this week :( hurricane threw a wrench in my plans. But I believe my async version of the tests is working but for some reason the simulated device refuses to connect so now I am working on fixing that.

@MarcinPlaza
Copy link

MarcinPlaza commented Nov 18, 2024

I have pushed my attempt to a new branch called electrical-protocol-async-v2, for now I have left an "Async_readme.txt" to bring whoever comes next up to speed. Note: I cannot promise the validity of any of the code so please assume it might be wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants