-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Alarm Docs #1073
Improve Alarm Docs #1073
Conversation
Hola, your friendly InvestiGator bot here with another message! Because this PR was closed/merged, I'm going to remove the docs preview for now. Have a great day! Go gators! 🐊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Mrinall! This is a good first attempt! The beginning and ends of this tutorial are great, and cover a great overview of why an alarm system has been implemented, and where someone can find more details about our specific implementation, ros_alarms
.
Unfortunately, the documentation you write near the middle of the file is likely too unfocused for a ros_alarms
introduction, as it focuses on general ROS services. You could consider moving some of your code into a separate tutorial about creating a ROS package with services and service files. However, inclusion of this material in documentation about a specific package like ros_alarms
is too unfocused.
Apologies for the wait for a review, please make your corrections and submit when you have a chance, thank you!
Fixed! Thank you for the feedback! |
…ly available info about ROS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Adds more documentation on ROS alarms, including the logic surrounding their implementations as well as potential applications.
Screenshot or Video
Click on the deployment link.
Related Issues
- Closes #1040
Testing
This is documentation so no testing is required.
About This PR