Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Alarm Docs #1073

Merged
merged 25 commits into from
Mar 5, 2024
Merged

Improve Alarm Docs #1073

merged 25 commits into from
Mar 5, 2024

Conversation

MrinallU
Copy link
Contributor

@MrinallU MrinallU commented Aug 28, 2023

Description

Adds more documentation on ROS alarms, including the logic surrounding their implementations as well as potential applications.

Screenshot or Video

Click on the deployment link.

Related Issues

- Closes #1040

Testing

This is documentation so no testing is required.

About This PR

  • I have updated documentation related to this change so that future members are aware of the changes I've made.

@uf-mil-bot
Copy link
Collaborator

uf-mil-bot commented Aug 28, 2023

Hola, your friendly InvestiGator bot here with another message!

Because this PR was closed/merged, I'm going to remove the docs preview for now.

Have a great day! Go gators! 🐊

@MrinallU MrinallU changed the title Update alarms.rst Improve Alarm Docs Aug 29, 2023
Copy link
Member

@cbrxyz cbrxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Mrinall! This is a good first attempt! The beginning and ends of this tutorial are great, and cover a great overview of why an alarm system has been implemented, and where someone can find more details about our specific implementation, ros_alarms.

Unfortunately, the documentation you write near the middle of the file is likely too unfocused for a ros_alarms introduction, as it focuses on general ROS services. You could consider moving some of your code into a separate tutorial about creating a ROS package with services and service files. However, inclusion of this material in documentation about a specific package like ros_alarms is too unfocused.

Apologies for the wait for a review, please make your corrections and submit when you have a chance, thank you!

@MrinallU
Copy link
Contributor Author

Hi Mrinall! This is a good first attempt! The beginning and ends of this tutorial are great, and cover a great overview of why an alarm system has been implemented, and where someone can find more details about our specific implementation, ros_alarms.

Unfortunately, the documentation you write near the middle of the file is likely too unfocused for a ros_alarms introduction, as it focuses on general ROS services. You could consider moving some of your code into a separate tutorial about creating a ROS package with services and service files. However, inclusion of this material in documentation about a specific package like ros_alarms is too unfocused.

Apologies for the wait for a review, please make your corrections and submit when you have a chance, thank you!

Fixed! Thank you for the feedback!

cbrxyz
cbrxyz previously approved these changes Mar 5, 2024
Copy link
Member

@cbrxyz cbrxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cbrxyz cbrxyz enabled auto-merge (squash) March 5, 2024 00:01
@cbrxyz cbrxyz merged commit e58b169 into master Mar 5, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add general documentation on ros_alarms system
3 participants