Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros2 navigator utils remote control #1195

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Jorge-R08
Copy link

Description

Migrated to ROS2 Navigator/utils/remote_control/navigator_joystick_control & Navigator/utils/remote_control/navigator_emergency_control

Screenshot or Video

ROS 2 migration, no screenshot or videos

Related Issues

Part of the ROS2 migration

- Closes #XXX

Testing

About This PR

  • I have updated documentation related to this change so that future members are aware of the changes I've made.

Copy link
Member

@cbrxyz cbrxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just the time calls need to be fixed

@@ -80,15 +88,15 @@ def check_for_timeout(self, joy: Joy):
# No change in state
# The controller times out after 15 minutes
if (
rospy.Time.now() - self.last_joy.header.stamp > rospy.Duration(15 * 60)
rclpy.Time.now() - self.last_joy.header.stamp > rclpy.Duration(15 * 60)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rclpy.Time.now() is not allowed in ROS 2

self.reset()

else:
joy.header.stamp = (
rospy.Time.now()
rclpy.Time.now()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants