Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shibboleth - 1.3.2. Testing the log in process #1077

Closed
1 of 4 tasks
kosarko opened this issue Nov 14, 2023 · 2 comments
Closed
1 of 4 tasks

Shibboleth - 1.3.2. Testing the log in process #1077

kosarko opened this issue Nov 14, 2023 · 2 comments

Comments

@kosarko
Copy link
Member

kosarko commented Nov 14, 2023

Expectation

see the section in #1066

What's not working as expected

@kosarko
Copy link
Member Author

kosarko commented Dec 8, 2023

pick a facet from homepage while logged out; login from search page using shibboleth takes you back to home page not search results (this works correctly with local logins)

@kosarko
Copy link
Member Author

kosarko commented Jan 22, 2024

We've agreed that it's not necessary to list the attribute values as provided by and IDP (and it's the IDP's job to show what it releases). The text of the EULA/privacy policy (which is displayed for new users) can mention the attribute names (similar to shibboleth-sp metadata) in text.

The text can be changed in https://github.com/dataquest-dev/dspace-angular/tree/b45168ebda1187fa54f10f496fb6e766437b0684/src/app/info and/or is processed with the translate pipeline (see https://github.com/dataquest-dev/dspace-angular/blob/b45168ebda1187fa54f10f496fb6e766437b0684/src/app/info/end-user-agreement/end-user-agreement-content/end-user-agreement-content.component.html#L1)

@kosarko kosarko closed this as completed Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants